Better error reporting in queuedjob if indexing fails.

wilr · Jul 27, 2021 · b8bc33b · b8bc33b
1 parent a3dcbed
commit b8bc33b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/src/Extensions/AlgoliaObjectExtension.php b/src/Extensions/AlgoliaObjectExtension.php
@@ -225,6 +225,8 @@ public function doImmediateIndexInAlgolia()
                 )
             );
 
+            $this->owner->AlgoliaError = $e->getMessage();
+
             return false;
         }
     }
@@ -246,7 +248,7 @@ public function onAfterUnpublish()
      */
     public function removeFromAlgolia()
     {
-        if (!$this->owner->AlgoliaIndexed) {
+        if (!$this->owner->AlgoliaUUID) {
             // Not in the index, so skipping
             return false;
         }
@@ -283,6 +285,7 @@ public function assignAlgoliaUUID($writeImmediately = true)
     {
         $uuid = Uuid::uuid4();
         $this->owner->AlgoliaUUID = $uuid->toString();
+
         if ($writeImmediately) {
             $this->updateAlgoliaFields(['AlgoliaUUID' => "'" . $this->owner->AlgoliaUUID . "'"]);
         }

diff --git a/src/Jobs/AlgoliaIndexItemJob.php b/src/Jobs/AlgoliaIndexItemJob.php
@@ -106,9 +106,12 @@ public function process()
             if (!$obj->AlgoliaUUID) {
                 $obj->assignAlgoliaUUID();
             }
-            $obj->doImmediateIndexInAlgolia();
 
-            $this->addMessage('Record #'. $id .' indexed as objectID '. $obj->AlgoliaUUID);
+            if ($obj->doImmediateIndexInAlgolia()) {
+                $this->addMessage('Record #'. $id .' successfully indexed as objectID '. $obj->AlgoliaUUID);
+            } else {
+                $this->addMessage('Record #'. $id .' failed to be indexed: '. $obj->AlgoliaError);
+            }
 
             unset($obj);
         }