Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PostgreSQL/PostGIS DB #27

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

pka
Copy link

@pka pka commented Jan 29, 2022

I'd like to add an additional data provider, but since I'm from the PostgreSQL/PostGIS/TimescaleDB camp, I've added support for Postgres first. I've tested compatibility with all providers which don't require a login.

Thanks for this great project and service!

@ysavary
Copy link
Member

ysavary commented Feb 4, 2022

Hi @pka,

Thank you for this PR!

You are already using postgres, and you want to use this project for your own usage (I have no problem with this as long as you respect the license) or your goal is to write a new provider for winds.mobi?

Your abstraction class for the storage is a good idea, maybe could you do a separate PR for this?

I'm not fundamentally against migrating from mongodb to PostgreSQL/PostGIS but it will require many additional tasks:

What are the benefits to migrate to PostgreSQL/PostGIS ?

@pka
Copy link
Author

pka commented Feb 4, 2022

As a first step I only want to test the new provider on my local PG database. If I have time for it, I'd like to combine it with https://github.com/Meisterschueler/ogn-python which also uses PostGIS/TimescaleDB.

I don't want to convince you to migrate to PostgreSQL, it's just that I never worked with MongoDB before. So no plans for porting frontend and API to PG. I'm absolutely fine with reducing the PR to a DB abstraction and maintaining the PG driver in a (private) branch. Maybe we could talk about this and other ideas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants