build attributes

windwalker-io · Dec 10, 2024 · a420142 · a420142
1 parent fef1fc8
commit a420142
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/packages/dom/src/DOMElement.php b/packages/dom/src/DOMElement.php
@@ -407,8 +407,13 @@ public function createChild(string $name, array $attributes = [], $content = nul
      *
      * @return  string
      */
+    #[\Deprecated(message: 'Use HTMLElement::buildAttributes() instead.')]
     public static function buildAttributes(array|NativeDOMElement $attributes, ?string $type = null): string
     {
+        if ($type === null || $type === static::HTML) {
+            return HTMLElement::buildAttributes($attributes);
+        }
+
         if ($attributes instanceof NativeDOMElement) {
             $attributes = array_map(
                 fn(DOMAttr $attr) => $attr->value,

diff --git a/packages/dom/src/HTMLElement.php b/packages/dom/src/HTMLElement.php
@@ -120,13 +120,13 @@ public function render(bool $formatOutput = false): string
             throw new \LogicException('Please attach Element to a Document before render it.');
         }
 
-        $formatOutputBak = $this->ownerDocument->formatOutput;
-
-        $this->ownerDocument->formatOutput = $formatOutput;
+        // $formatOutputBak = $this->ownerDocument->formatOutput;
+        //
+        // $this->ownerDocument->formatOutput = $formatOutput;
 
         $result = HTML5Factory::saveHtml($this);
 
-        $this->ownerDocument->formatOutput = $formatOutputBak;
+        // $this->ownerDocument->formatOutput = $formatOutputBak;
 
         return $result;
     }