Update to use Ghost’s user-editable navigation #7
Conversation
|
eep I just noticed there’s a homepage header background that shows up after scrolling a bit on mobile, I’m not sure this update preserves that… and also the sandbox site has lost its theme (probably when the Heroku dyno went to sleep), so that setup needs some refining 😯 I’ll follow up re the header background in the morning 🤞🏻 |
|
ah it does still show up! I’m not sure how exactly and maybe it would benefit from alignment with these changes but I think it’s fine for now at least haha re the sandbox problem, my true dream is to create a Heroku deployment for every pull request, with something like this approach to include the theme in the Git commit vs uploading a |
|
How does the blog page look for you? I downloaded and opened this branch locally and the header background doesn't show up on the blog page for me. I think it might have to do with the way I set up routes to the blog page. Mine looks like this https://pastebin.com/nu6J2PLQ Only way it works on my end is if I add
to the .header class. |
|
Thanks for catching that! In It’s visible in the sandbox… for now 😆 |
backspace
force-pushed
the
nav
branch
3 times, most recently
from
4dfb251 to
f3b8e3c
Compare
This will allow theme PRs to include a .content-overrides directory that gets copied to the Heroku deployment so redirects.json and routes.yaml persist. I don’t love it because it means PRs will have spurious files but it’ll work for now…
This breaks current-page-tracking and overapplies a style meant only for certain pages.
This is out of sync on mobile but it’s closer…
The border was 0 because of the cascade 😐
Since this is only used once now, no need to use a partial.
It took me a while to understand that a checkbox is what was revealing the content!
This was used to style the menu differently on the homepage but it’s now handled in CSS.
Without this short-named items could wrap.
|
I achieved my dream of a preview deployment for every PR! It required an unpleasant workaround because of how redirects and routes in the filesystem vs the database and don’t survive on Heroku’s ephemeral filesystem: the PR has a But now you can see on the preview that the blog has the proper header:
|
|
If you think this is ready for merging, @FarfamaH, you could “approve” the pull request 🤓
If there are any conflicts with your work on #4, let me know if you want to pair on resolving them. |
This closes #3. It converts the theme to use Ghost’s built-in navigation features rather than hard-coding links to pages. That means it’ll be easier for non-computer nerds to keep the site updated 🥳
You can check it out on the theme “sandbox” site. It has different navigation than the true site to highlight this difference.