chore!: remove the cryptobox-migrate feature

[istankovic]

All clients have moved away from cryptobox so it doesn't make sense to have this.

📓 This is a breaking change.

[github-actions]

Bencher Report

Branch	ivan/remove-cryptobox-migrate
Testbed	ubuntu-latest

Click to view all benchmark results

Benchmark	Latency	milliseconds (ms)
Commit add f(group size)/cs1/mem/1002	📈 view plot 🚷 view threshold	20.43 ms
Commit add f(group size)/cs1/mem/2	📈 view plot 🚷 view threshold	7.40 ms
Commit add f(group size)/cs1/mem/202	📈 view plot 🚷 view threshold	10.39 ms
Commit add f(group size)/cs1/mem/402	📈 view plot 🚷 view threshold	12.57 ms
Commit add f(group size)/cs1/mem/602	📈 view plot 🚷 view threshold	16.21 ms
Commit add f(group size)/cs1/mem/802	📈 view plot 🚷 view threshold	18.43 ms
Commit add f(number clients)/cs1/mem/1002	📈 view plot 🚷 view threshold	1,001.50 ms
Commit add f(number clients)/cs1/mem/2	📈 view plot 🚷 view threshold	7.45 ms
Commit add f(number clients)/cs1/mem/202	📈 view plot 🚷 view threshold	86.89 ms
Commit add f(number clients)/cs1/mem/402	📈 view plot 🚷 view threshold	226.35 ms
Commit add f(number clients)/cs1/mem/602	📈 view plot 🚷 view threshold	431.94 ms
Commit add f(number clients)/cs1/mem/802	📈 view plot 🚷 view threshold	682.08 ms
Commit pending proposals f(group size)/cs1/mem/1002	📈 view plot 🚷 view threshold	127.07 ms
Commit pending proposals f(group size)/cs1/mem/2	📈 view plot 🚷 view threshold	29.02 ms
Commit pending proposals f(group size)/cs1/mem/202	📈 view plot 🚷 view threshold	47.40 ms
Commit pending proposals f(group size)/cs1/mem/402	📈 view plot 🚷 view threshold	64.55 ms
Commit pending proposals f(group size)/cs1/mem/602	📈 view plot 🚷 view threshold	82.09 ms
Commit pending proposals f(group size)/cs1/mem/802	📈 view plot 🚷 view threshold	97.87 ms
Commit pending proposals f(pending size)/cs1/mem/1	📈 view plot 🚷 view threshold	20.25 ms
Commit pending proposals f(pending size)/cs1/mem/101	📈 view plot 🚷 view threshold	118.07 ms
Commit pending proposals f(pending size)/cs1/mem/21	📈 view plot 🚷 view threshold	37.43 ms
Commit pending proposals f(pending size)/cs1/mem/41	📈 view plot 🚷 view threshold	58.46 ms
Commit pending proposals f(pending size)/cs1/mem/61	📈 view plot 🚷 view threshold	77.41 ms
Commit pending proposals f(pending size)/cs1/mem/81	📈 view plot 🚷 view threshold	98.76 ms
Commit remove f(group size)/cs1/mem/1002	📈 view plot 🚷 view threshold	30.07 ms
Commit remove f(group size)/cs1/mem/2	📈 view plot 🚷 view threshold	6.89 ms
Commit remove f(group size)/cs1/mem/202	📈 view plot 🚷 view threshold	9.65 ms
Commit remove f(group size)/cs1/mem/402	📈 view plot 🚷 view threshold	13.55 ms
Commit remove f(group size)/cs1/mem/602	📈 view plot 🚷 view threshold	18.37 ms
Commit remove f(group size)/cs1/mem/802	📈 view plot 🚷 view threshold	22.80 ms
Commit remove f(number clients)/cs1/mem/1002	📈 view plot 🚷 view threshold	34.04 ms
Commit remove f(number clients)/cs1/mem/2	📈 view plot 🚷 view threshold	139.76 ms
Commit remove f(number clients)/cs1/mem/202	📈 view plot 🚷 view threshold	117.91 ms
Commit remove f(number clients)/cs1/mem/402	📈 view plot 🚷 view threshold	97.43 ms
Commit remove f(number clients)/cs1/mem/602	📈 view plot 🚷 view threshold	75.08 ms
Commit remove f(number clients)/cs1/mem/802	📈 view plot 🚷 view threshold	53.94 ms
Commit update f(group size)/cs1/mem/1002	📈 view plot 🚷 view threshold	139.36 ms
Commit update f(group size)/cs1/mem/2	📈 view plot 🚷 view threshold	7.24 ms
Commit update f(group size)/cs1/mem/202	📈 view plot 🚷 view threshold	35.23 ms
Commit update f(group size)/cs1/mem/402	📈 view plot 🚷 view threshold	60.60 ms
Commit update f(group size)/cs1/mem/602	📈 view plot 🚷 view threshold	88.21 ms
Commit update f(group size)/cs1/mem/802	📈 view plot 🚷 view threshold	113.95 ms

🐰 View full continuous benchmarking report in Bencher

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.14%. Comparing base (39137b0) to head (d7d3e6c).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #942      +/-   ##
==========================================
- Coverage   79.27%   79.14%   -0.14%     
==========================================
  Files         113      113              
  Lines       20853    20713     -140     
==========================================
- Hits        16532    16393     -139     
+ Misses       4321     4320       -1     

Files with missing lines	Coverage Δ
crypto-ffi/src/generic/context/proteus.rs	0.00% <ø> (ø)
crypto-ffi/src/generic/mod.rs	13.10% <ø> (+0.01%)	⬆️
crypto/src/error/mod.rs	100.00% <ø> (ø)
crypto/src/lib.rs	37.50% <ø> (ø)
crypto/src/proteus.rs	47.66% <ø> (-11.80%)	⬇️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39137b0...d7d3e6c. Read the comment docs.

[coriolinus]

I love getting rid of obsolete features!

[coriolinus]

Great job that we can get rid of this entirely!

[coriolinus]

Oops, I misread the GH interface. We're not deleting the file entirely, but still, great to remove this much code from it.

I hadn't previously understood the implications of removing the Cryptobox migration. This code isn't wrong, strictly, but should probably not be merged before August 2025.