Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: unread archived conversations count [WPB-4437] #2103

Merged
merged 3 commits into from
Oct 2, 2023

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Sep 28, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Added query for getting unread archived conversations count

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

wireapp/wire-android#2288

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 28, 2023

Unit Test Results

   361 files   -   77     361 suites   - 77   22s ⏱️ - 1m 58s
2 039 tests  - 343  1 971 ✔️  - 307  68 💤  - 36  0 ±0 

Results for commit b25dba8. ± Comparison against base commit dab0ee5.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Sep 28, 2023

Datadog Report

All test runs 4fdf7a4 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 1971 68 6m 53.11s Link
kalium-jvm 0 0 0 2281 104 10m 45s Link

@Garzas Garzas requested review from a team, yamilmedina, MohamadJaara and vitorhugods and removed request for a team September 28, 2023 13:52
Copy link
Contributor

@gongracr gongracr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking beautiful 🦋

@Garzas Garzas added this pull request to the merge queue Oct 2, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 2, 2023
@Garzas Garzas enabled auto-merge October 2, 2023 06:04
@codecov-commenter
Copy link

Codecov Report

Merging #2103 (b25dba8) into develop (dab0ee5) will increase coverage by 0.01%.
The diff coverage is 88.88%.

@@              Coverage Diff              @@
##             develop    #2103      +/-   ##
=============================================
+ Coverage      57.87%   57.89%   +0.01%     
  Complexity        24       24              
=============================================
  Files           1014     1015       +1     
  Lines          38271    38286      +15     
  Branches        3490     3490              
=============================================
+ Hits           22149    22164      +15     
  Misses         14631    14631              
  Partials        1491     1491              
Files Coverage Δ
.../logic/data/conversation/ConversationRepository.kt 65.88% <100.00%> (+0.35%) ⬆️
.../ObserveArchivedUnreadConversationsCountUseCase.kt 100.00% <100.00%> (ø)
...um/persistence/dao/conversation/ConversationDAO.kt 100.00% <ø> (ø)
...ersistence/dao/conversation/ConversationDAOImpl.kt 66.83% <100.00%> (+0.16%) ⬆️
...um/logic/feature/conversation/ConversationScope.kt 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dab0ee5...b25dba8. Read the comment docs.

@Garzas Garzas added this pull request to the merge queue Oct 2, 2023
Merged via the queue into develop with commit a7760c3 Oct 2, 2023
@Garzas Garzas deleted the feat/unread-conversations-events branch October 2, 2023 06:55
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. 🚨 Potential breaking changes 👕 size: M type: feature ✨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants