ci: enable KVM for faster emulator #2390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wtf 🏎️🚀
|
Datadog ReportBranch report: ✅ 0 Failed, 2745 Passed, 137 Skipped, 8m 36.05s Wall Time |
MohamadJaara
approved these changes
Jan 22, 2024
|
Now the tests and emulator run fast. But the emulator is failing to shutdown xD |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #2390 +/- ##
====================================================
Coverage ? 57.98%
Complexity ? 21
====================================================
Files ? 1164
Lines ? 45008
Branches ? 4230
====================================================
Hits ? 26096
Misses ? 17029
Partials ? 1883 Continue to review full report in Codecov by Sentry.
|
yamilmedina
approved these changes
Jan 30, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jan 30, 2024
* ci: enable KVM for faster emulator * ci: upgrade actions to v4 * ci: fix wrong action name --------- Co-authored-by: Yamil Medina <[email protected]>
5 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 30, 2024
* ci: enable KVM for faster emulator * ci: upgrade actions to v4 * ci: fix wrong action name --------- Co-authored-by: Vitor Hugo Schwaab <[email protected]> Co-authored-by: Yamil Medina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
GitHub is now providing faster hardware for open-source projects.
We should be able to use the free 4vCPU runners + KVM to run the emulator faster, which is sometime taking >10min to boot, leading to timeouts.
Solutions
Replace BuildJet with GitHub runner + enable KVM and caching.
Side note:
Testing
This PR will test things :)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.