Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mls): fetch other user supported protocols when resolving 1:1 conversation [WPB-5048] #2405

Conversation

vitorhugods
Copy link
Member

@vitorhugods vitorhugods commented Jan 25, 2024


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

We're not fetching the supported protocols by the other user in all scenarios when resolving 1:1

Causes

Not yet implemented.

Solutions

Re-fetch the supported protocols when processing events and performing actions. In places, like:

  • Accepting connection request,
  • Opening a conversation,
  • Receiving a MLS Welcome event,
  • Receiving a New Conversation event,

Added a flag that tells if this behaviour is wanted or not in the OneOnOneResolver.

In case of a failure during fetching, just accept whatever is in the DB to avoid bumps due to connection flakyness.

Testing

Test Coverage

  • I have added automated test to this contribution

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@vitorhugods vitorhugods changed the title fix(mls) fetch other user supported protocols when resolving 1:1 conversation [WPB-5048] fix(mls): fetch other user supported protocols when resolving 1:1 conversation [WPB-5048] Jan 25, 2024
Copy link
Contributor

github-actions bot commented Jan 25, 2024

Test Results

2 759 tests   2 638 ✔️  31s ⏱️
   480 suites     121 💤
   480 files           0

Results for commit 8c9a3d0.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release/candidate@457475e). Click here to learn what that means.

Additional details and impacted files
@@                 Coverage Diff                  @@
##             release/candidate    #2405   +/-   ##
====================================================
  Coverage                     ?   58.41%           
  Complexity                   ?       21           
====================================================
  Files                        ?     1161           
  Lines                        ?    44765           
  Branches                     ?     4182           
====================================================
  Hits                         ?    26151           
  Misses                       ?    16730           
  Partials                     ?     1884           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 457475e...8c9a3d0. Read the comment docs.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Jan 25, 2024

Datadog Report

Branch report: fix/mls/one-on-one/fetch-other-user-supported-protocols-when-resolving-conversation
Commit report: c2b1cb5
Test service: kalium-jvm

✅ 0 Failed, 2772 Passed, 105 Skipped, 8m 53s Wall Time

…user-supported-protocols-when-resolving-conversation
…user-supported-protocols-when-resolving-conversation
@vitorhugods vitorhugods merged commit ee75ec7 into release/candidate Jan 26, 2024
17 checks passed
@vitorhugods vitorhugods deleted the fix/mls/one-on-one/fetch-other-user-supported-protocols-when-resolving-conversation branch January 26, 2024 12:22
github-actions bot pushed a commit that referenced this pull request Jan 26, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants