-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mls): fetch other user supported protocols when resolving 1:1 conversation [WPB-5048] #2405
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #2405 +/- ##
====================================================
Coverage ? 58.41%
Complexity ? 21
====================================================
Files ? 1161
Lines ? 44765
Branches ? 4182
====================================================
Hits ? 26151
Misses ? 16730
Partials ? 1884 Continue to review full report in Codecov by Sentry.
|
Datadog ReportBranch report: ✅ 0 Failed, 2772 Passed, 105 Skipped, 8m 53s Wall Time |
…user-supported-protocols-when-resolving-conversation
…user-supported-protocols-when-resolving-conversation
…versations (#2405) (#2418) Co-authored-by: Vitor Hugo Schwaab <[email protected]>
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
We're not fetching the supported protocols by the other user in all scenarios when resolving 1:1
Causes
Not yet implemented.
Solutions
Re-fetch the supported protocols when processing events and performing actions. In places, like:
MLS Welcome
event,New Conversation
event,Added a flag that tells if this behaviour is wanted or not in the
OneOnOneResolver
.In case of a failure during fetching, just accept whatever is in the DB to avoid bumps due to connection flakyness.
Testing
Test Coverage
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.