-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Observe self client certificate revocation (WPB-6145) - cherrypick #2408
Merged
ohassine
merged 1 commit into
develop
from
cherry-pick-show_your_device_cert_revoked_dialog
Jan 25, 2024
Merged
feat: Observe self client certificate revocation (WPB-6145) - cherrypick #2408
ohassine
merged 1 commit into
develop
from
cherry-pick-show_your_device_cert_revoked_dialog
Jan 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(MLS): check revocation list * feat(MLS): cover CheckRevocationListUseCase with unit test * chore: detekt * chore: apply new changes from CC * feat: store urls with expiration time * feat: pass url as param to the use case * chore: detekt * chore: unit test * feat: Show dialog when current user's certificate is revoked * feat: update unit test for CheckRevocationListUseCase * chore: detekt * chore: cleanup * chore: resolve conflicts
ohassine
requested review from
a team,
yamilmedina,
MohamadJaara,
mchenani,
Garzas and
saleniuk
and removed request for
a team
January 25, 2024 14:33
Test Results2 490 tests - 376 2 423 ✔️ - 338 26s ⏱️ - 2m 27s Results for commit 008a66a. ± Comparison against base commit 91a154c. This pull request removes 2866 and adds 2490 tests. Note that renamed tests count towards both.
This pull request removes 105 skipped tests and adds 67 skipped tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
mchenani
approved these changes
Jan 25, 2024
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 2 Passed Test Services
|
yamilmedina
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Cherry pick from the original PR:
#2384
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.