-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create worker to periodically check CRL (WPB-3243) - cherrypick #2410
feat: create worker to periodically check CRL (WPB-3243) - cherrypick #2410
Conversation
* feat(MLS): check revocation list * feat(MLS): cover CheckRevocationListUseCase with unit test * chore: detekt * chore: apply new changes from CC * feat: store urls with expiration time * feat: pass url as param to the use case * chore: detekt * chore: unit test * chore: cleanup * feat: observe current client certificate * feat: unit test * chore: remove ObserveCertificateForCurrentClientUseCase * feat: create worker to periodically check CRL * chore: detekt * chore: cleanup * chore: cleanup * chore: cover CrlRepository with unit test * chore: cover CheckCrlWorker with unit test * chore: address comments
Test Results2 495 tests - 374 2 428 ✔️ - 336 28s ⏱️ - 2m 28s Results for commit 21de142. ± Comparison against base commit aa9e9c4. This pull request removes 2869 and adds 2495 tests. Note that renamed tests count towards both.
This pull request removes 105 skipped tests and adds 67 skipped tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just 1 question :)
...src/commonMain/kotlin/com/wire/kalium/logic/data/e2ei/CertificateRevocationListRepository.kt
Outdated
Show resolved
Hide resolved
…evocation_list' into cherry-pick_periodically_check_revocation_list
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 2 Passed Test Services
|
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Cherry pick from the original PR:
#2397
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.