-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: handle legal hold failure result when sending connection [WPB-4395] #2419
Conversation
Test Results2 247 tests - 632 2 204 ✔️ - 570 10s ⏱️ - 2m 20s Results for commit 346645a. ± Comparison against base commit 76d6385. This pull request removes 2879 and adds 2247 tests. Note that renamed tests count towards both.
This pull request removes 105 skipped tests and adds 43 skipped tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2419 +/- ##
==========================================
Coverage 58.41% 58.41%
Complexity 21 21
==========================================
Files 1162 1162
Lines 44813 44824 +11
Branches 4184 4187 +3
==========================================
+ Hits 26176 26184 +8
- Misses 16752 16754 +2
- Partials 1885 1886 +1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 2 Passed Test Services
|
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Currently we're not taking legal hold into account when sending connection requests which results in request not being completed without any explanation.
Solutions
Handle
missing-legalhold-consent
response label and return new type of failed result inSendConnectionRequestUseCase
.Testing
Test Coverage (Optional)
How to Test
Send a connection request to a person which is under legal hold or send a connection request to anyone while you are under legal hold.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.