chore: bring back architecture test after being ignored #2432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
the
cherry-pick
yamilmedina
requested review from
a team,
yamilmedina,
borichellow,
vitorhugods,
mchenani and
ohassine
and removed request for
a team
ohassine
approved these changes
Jan 30, 2024
yamilmedina
deleted the
fix/enable-architecture-test-again-cherry-pick
branch
…enable-architecture-test-again-cherry-pick
mchenani
approved these changes
Feb 7, 2024
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 2 Passed Test Services
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
yamilmedina
deleted the
fix/enable-architecture-test-again-cherry-pick
branch
augustocdias
pushed a commit
that referenced
this pull request
Feb 13, 2024
* chore: bring back architecture test after being ignored (#2431) * Empty-Commit * remove un-needed changes * chore: reenable test --------- Co-authored-by: Yamil Medina <[email protected]> Co-authored-by: Mojtaba Chenani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick from the original PR:
PR Submission Checklist for internal contributors
The PR Title
The PR Description
What's new in this PR?
Issues
Architecture tests are ignored
Causes (Optional)
Circular dependencies, and other code smells, are not being caught.
Solutions
Renable, and supress (for now) failed tests.
Testing
Test Coverage (Optional)
Notes (Optional)
Tickets are going to be created as tech debt to be solved, at least for develop as a last resort.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References