Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core-crypto): upgrade core-crypto to rc 35 (WPB-6347) #2437

Merged
merged 9 commits into from
Feb 1, 2024

Conversation

mchenani
Copy link
Contributor


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Upgrade CoreCrypto to RC 35

Testing

Nothing to test!


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Jan 31, 2024

Test Results

2 888 tests   2 766 ✔️  2m 54s ⏱️
   507 suites     122 💤
   507 files           0

Results for commit 9cc9fd9.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Jan 31, 2024

Datadog Report

All test runs 29dd34c 🔗

2 Total Test Services: 0 Failed, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Test Service View
kalium-ios 0 0 0 2642 128 8m 40.09s Link
kalium-jvm 0 0 0 2766 122 9m 8s Link

Base automatically changed from release/fix/e2ei/get-my-cleints-certs to release/candidate February 1, 2024 12:06
Copy link
Contributor

@borichellow borichellow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect :)

@mchenani mchenani merged commit 671bfb7 into release/candidate Feb 1, 2024
17 checks passed
@mchenani mchenani deleted the release/chore/update-corecrypto-rc35 branch February 1, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants