fix: changing profile avatar doesn't reflect update (WPB-5494) #2444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
* fix: remove SELECT changes from updateUser query * fix: add transactionWithResult when updateUser and return select changes * test: add tests for observing user details by id
github-actions
bot
added
the
cherry-pick
…ry as it is not used anymore
github-actions
bot
added
🚨 Potential breaking changes
👕 size: S
type: bug / fix 🐞
labels
Test Results2 501 tests - 379 2 434 ✔️ - 341 32s ⏱️ - 2m 5s Results for commit 831c66f. ± Comparison against base commit f11edf5. This pull request removes 2880 and adds 2501 tests. Note that renamed tests count towards both.This pull request removes 105 skipped tests and adds 67 skipped tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Datadog ReportBranch report: ✅ 0 Failed, 256 Passed, 13 Skipped, 5m 52s Wall Time |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2444 +/- ##
==========================================
Coverage 58.42% 58.42%
Complexity 21 21
==========================================
Files 1162 1162
Lines 44829 44811 -18
Branches 4187 4185 -2
==========================================
- Hits 26191 26182 -9
+ Misses 16752 16748 -4
+ Partials 1886 1881 -5
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
alexandreferris
requested review from
a team,
yamilmedina,
borichellow,
MohamadJaara,
Garzas and
saleniuk
and removed request for
a team
vitorhugods
approved these changes
Feb 5, 2024
yamilmedina
approved these changes
Feb 5, 2024
augustocdias
pushed a commit
that referenced
this pull request
Feb 13, 2024
* fix: changing profile avatar doesn't reflect update (WPB-5494) (#2443) * fix: remove SELECT changes from updateUser query * fix: add transactionWithResult when updateUser and return select changes * test: add tests for observing user details by id * fix: add UPDATE OR FAIL to update query and remove select changes query as it is not used anymore * fix: remove unused select changes query and change return type of updateUser to Unit * fix: adjust existing tests --------- Co-authored-by: Alexandre Ferris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick from the original PR:
PR Submission Checklist for internal contributors
The PR Title
The PR Description
What's new in this PR?
Issues
When changing user profile avatar it wasn't being reflected in other screens in the app
Causes (Optional)
the query was a transaction returning , thus sqldelight not emitting the update on the table.
Solutions
Remove transaction and from the query and add on the DAOImpl to properly reflect the changes upwards when needed.
Testing
How to Test
Notes (Optional)
@vitorhugods opened an issue on SQLDelight : sqldelight/sqldelight#5001