feat(monkeys): Add support for 2FA during login [WPB-6289] #2445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augustocdias
requested review from
typfel,
mchenani,
MohamadJaara and
vitorhugods
augustocdias
force-pushed
the
feat/monkeys/2fa
branch
from
cf3f569 to
5e8ba6c
Compare
augustocdias
force-pushed
the
feat/monkeys/2fa
branch
from
5e8ba6c to
c6e21e2
Compare
vitorhugods
reviewed
Feb 13, 2024
vitorhugods
approved these changes
Feb 13, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2445 +/- ##
==========================================
Coverage 58.37% 58.38%
Complexity 21 21
==========================================
Files 1171 1171
Lines 45296 45296
Branches 4289 4289
==========================================
+ Hits 26443 26445 +2
+ Misses 16928 16926 -2
Partials 1925 1925 see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportBranch report: ✅ 0 Failed, 2784 Passed, 122 Skipped, 9m 52.08s Wall Time |
MohamadJaara
approved these changes
Feb 19, 2024
jschumacher-wire
pushed a commit
that referenced
this pull request
Mar 6, 2024
* feat(monkeys): Add support for 2FA during login [WPB-6289] * fix * detekt * add workaround to reuse code * detekt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
This adds support to 2FA in the login of the monkeys. A new flag was added in the backend configuration to indicate the need for it during authentication.
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.