chore: add formatted logs for mls observability (WPB-6335) #2446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #2446 +/- ##
====================================================
Coverage ? 58.37%
Complexity ? 21
====================================================
Files ? 1166
Lines ? 45146
Branches ? 4236
====================================================
Hits ? 26353
Misses ? 16906
Partials ? 1887 Continue to review full report in Codecov by Sentry.
|
Datadog ReportBranch report: ✅ 0 Failed, 2767 Passed, 122 Skipped, 8m 47.05s Wall Time |
yamilmedina
requested review from
a team,
alexandreferris,
vitorhugods,
mchenani,
ohassine and
saleniuk
and removed request for
a team
alexandreferris
approved these changes
Feb 5, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Feb 5, 2024
* chore: extract to common logger ext function for json logs * chore: adjust logs to format and add data for mls like epoch and protocol details * chore: adjust logs to format for joining via commit and when stale epoch * chore: adjust logs to format for joining via commit and when stale epoch * chore: adjust logs to format for joining via commit and when stale epoch * chore: adjust mapping * chore: adjust mapping * chore: add log to unpacker with delayed info
7 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 6, 2024
* chore: add formatted logs for mls observability (WPB-6335) (#2446) * chore: extract to common logger ext function for json logs * chore: adjust logs to format and add data for mls like epoch and protocol details * chore: adjust logs to format for joining via commit and when stale epoch * chore: adjust logs to format for joining via commit and when stale epoch * chore: adjust logs to format for joining via commit and when stale epoch * chore: adjust mapping * chore: adjust mapping * chore: add log to unpacker with delayed info * Empty-Commit --------- Co-authored-by: Yamil Medina <[email protected]>
augustocdias
pushed a commit
that referenced
this pull request
Feb 13, 2024
* chore: add formatted logs for mls observability (WPB-6335) (#2446) * chore: extract to common logger ext function for json logs * chore: adjust logs to format and add data for mls like epoch and protocol details * chore: adjust logs to format for joining via commit and when stale epoch * chore: adjust logs to format for joining via commit and when stale epoch * chore: adjust logs to format for joining via commit and when stale epoch * chore: adjust mapping * chore: adjust mapping * chore: add log to unpacker with delayed info * Empty-Commit --------- Co-authored-by: Yamil Medina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
MLS was missing some logs format so we can monitor and create dashboards for observability
Causes (Optional)
Difficult to track issues when this happens.
Solutions
Testing
Test Coverage (Optional)
How to Test
On AR using this branch if you use the app, you should see logs there formatted.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.