Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Get Clients certs cherry-pick #2465

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

borichellow
Copy link
Contributor

Manual cherry-pick of RC PR

Copy link
Contributor

github-actions bot commented Feb 7, 2024

Test Results

2 118 tests   - 771   2 056 ✔️  - 711   15s ⏱️ - 2m 17s
   385 suites  - 124        62 💤  -   60 
   385 files    - 124          0 ±    0 

Results for commit a9801f3. ± Comparison against base commit a7687dc.

This pull request removes 2889 and adds 2118 tests. Note that renamed tests count towards both.
PocIntegrationTest ‑ givenApiWhenGettingACMEDirectoriesThenReturnAsExpectedBasedOnNetworkState
PocIntegrationTest ‑ givenEmailAndPasswordWhenLoggingInThenRegisterClientAndLogout
com.wire.kalium.HttpClientConnectionSpecsTest ‑ givenTheHttpClientIsCreated_ThenEnsureOnlySupportedSpecsArePresent[jvm]
com.wire.kalium.api.base.authenticated.notification.AccessUpdateTest ‑ givenPayloadWithAccessRoleAndDeprecatedAccessRoleField_whenDecoding_thenDeprecatedFieldIsPreferred[jvm]
com.wire.kalium.api.base.authenticated.notification.AccessUpdateTest ‑ givenPayloadWithDeprecatedAccessRoleField_whenDecoding_thenSuccess[jvm]
com.wire.kalium.api.base.authenticated.notification.AccessUpdateTest ‑ givenPayload_whenDecoding_thenSuccess[jvm]
com.wire.kalium.api.common.ACMEApiTest ‑ givenNoLocationInHeader_whenCallingSendAcmeRequestApi_theResponseShouldBeConfigureCorrectly[jvm]
com.wire.kalium.api.common.ACMEApiTest ‑ givenNoNonce_whenCallingSendAcmeRequestApi_theResponseShouldBeMissingNonce[jvm]
com.wire.kalium.api.common.ACMEApiTest ‑ whenCallingGeTrustAnchorsApi_theResponseShouldBeConfigureCorrectly[jvm]
com.wire.kalium.api.common.ACMEApiTest ‑ whenCallingGetACMEDirectoriesApi_theResponseShouldBeConfigureCorrectly[jvm]
…
com.wire.kalium.cryptography.CryptoUtilsTest ‑ givenDummyText_whenEncryptedAndDecryptedWithAES256_returnsOriginalText[iosX64]
com.wire.kalium.cryptography.CryptoUtilsTest ‑ givenSomeDummyFile_whenEncryptedAndDecryptedWithAES256_returnsExpectedOriginalFile[iosX64]
com.wire.kalium.cryptography.CryptoUtilsTest ‑ givenSomeDummyFile_whenEncryptedAsAFileAndDecryptedWithAES256AsData_returnsExpectedOriginalFileContent[iosX64]
com.wire.kalium.cryptography.CryptoUtilsTest ‑ givenSomeDummyFile_whenEncryptedAsDataAndDecryptedWithAES256AsAFile_returnsExpectedOriginalFileContent[iosX64]
com.wire.kalium.cryptography.CryptoUtilsTest ‑ testGivenByteArray_whenCallingCalcMd5_returnsExpectedDigest[iosX64]
com.wire.kalium.cryptography.CryptoUtilsTest ‑ testGivenByteArray_whenCallingCalcSHA256_returnsExpectedDigest[iosX64]
com.wire.kalium.cryptography.E2EIClientTest ‑ givenClient_whenCallingCertificateRequest_ReturnNonEmptyResult[iosX64]
com.wire.kalium.cryptography.E2EIClientTest ‑ givenClient_whenCallingCheckOrderRequest_ReturnNonEmptyResult[iosX64]
com.wire.kalium.cryptography.E2EIClientTest ‑ givenClient_whenCallingCreateDpopToken_ReturnNonEmptyResult[iosX64]
com.wire.kalium.cryptography.E2EIClientTest ‑ givenClient_whenCallingFinalizeRequest_ReturnNonEmptyResult[iosX64]
…
This pull request removes 122 skipped tests and adds 62 skipped tests. Note that renamed tests count towards both.
PocIntegrationTest ‑ givenApiWhenGettingACMEDirectoriesThenReturnAsExpectedBasedOnNetworkState
PocIntegrationTest ‑ givenEmailAndPasswordWhenLoggingInThenRegisterClientAndLogout
com.wire.kalium.api.common.ACMEApiTest ‑ whenCallingGeTrustAnchorsApi_theResponseShouldBeConfigureCorrectly[jvm]
com.wire.kalium.api.common.ACMEApiTest ‑ whenCallingSendChallengeRequestApi_theResponseShouldBeConfigureCorrectly[jvm]
com.wire.kalium.api.v0.user.register.RegisterApiV0Test ‑ givenAValidEmail_whenActivationEmailWIthCode_theRequestShouldBeConfiguredCorrectly[jvm]
com.wire.kalium.api.v0.user.register.RegisterApiV0Test ‑ givenAValidEmail_whenRegisteringAccountWithEMail_theRequestShouldBeConfiguredCorrectly[jvm]
com.wire.kalium.api.v0.user.register.RegisterApiV0Test ‑ givenAValidEmail_whenSendingActivationEmail_theRequestShouldBeConfiguredCorrectly[jvm]
com.wire.kalium.api.v0.user.register.RegisterApiV0Test ‑ givenActivationCodeFail_thenErrorIsPropagated[jvm]
com.wire.kalium.api.v0.user.register.RegisterApiV0Test ‑ givenRegistrationFail_whenRegisteringAccountWithEMMail_thenErrorIsPropagated[jvm]
com.wire.kalium.api.v0.user.register.RegisterApiV0Test ‑ givenSendActivationCodeFail_thenErrorIsPropagated[jvm]
…
com.wire.kalium.cryptography.E2EIClientTest ‑ givenClient_whenCallingCertificateRequest_ReturnNonEmptyResult[iosX64]
com.wire.kalium.cryptography.E2EIClientTest ‑ givenClient_whenCallingCheckOrderRequest_ReturnNonEmptyResult[iosX64]
com.wire.kalium.cryptography.E2EIClientTest ‑ givenClient_whenCallingCreateDpopToken_ReturnNonEmptyResult[iosX64]
com.wire.kalium.cryptography.E2EIClientTest ‑ givenClient_whenCallingFinalizeRequest_ReturnNonEmptyResult[iosX64]
com.wire.kalium.cryptography.E2EIClientTest ‑ givenClient_whenCallingGetNewAccountRequest_ReturnNonEmptyResult[iosX64]
com.wire.kalium.cryptography.E2EIClientTest ‑ givenClient_whenCallingGetNewAuthzRequest_ReturnNonEmptyResult[iosX64]
com.wire.kalium.cryptography.E2EIClientTest ‑ givenClient_whenCallingGetNewDpopChallengeRequest_ReturnNonEmptyResult[iosX64]
com.wire.kalium.cryptography.E2EIClientTest ‑ givenClient_whenCallingGetNewOidcChallengeRequest_ReturnNonEmptyResult[iosX64]
com.wire.kalium.cryptography.E2EIClientTest ‑ givenClient_whenCallingGetNewOrderRequest_ReturnNonEmptyResult[iosX64]
com.wire.kalium.cryptography.E2EIClientTest ‑ givenClient_whenPassingAcmeDirectoryResponse_ReturnNonEmptyResult[iosX64]
…

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (a7687dc) 58.43% compared to head (a9801f3) 58.41%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2465      +/-   ##
=============================================
- Coverage      58.43%   58.41%   -0.02%     
  Complexity        21       21              
=============================================
  Files           1167     1167              
  Lines          45085    45100      +15     
  Branches        4201     4203       +2     
=============================================
+ Hits           26344    26346       +2     
- Misses         16858    16869      +11     
- Partials        1883     1885       +2     
Files Coverage Δ
...monMain/kotlin/com/wire/kalium/cryptography/IDs.kt 86.20% <100.00%> (ø)
.../e2ei/usecase/GetUserE2EIAllCertificatesUseCase.kt 100.00% <100.00%> (ø)
.../data/conversation/DecryptedMessageBundleMapper.kt 22.22% <0.00%> (-4.45%) ⬇️
...gic/data/conversation/MLSConversationRepository.kt 84.08% <50.00%> (-1.67%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7687dc...a9801f3. Read the comment docs.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Feb 7, 2024

Datadog Report

All test runs 7b663b8 🔗

2 Total Test Services: 0 Failed, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Test Service View
kalium-ios 0 0 0 2056 62 6m 7.12s Link
kalium-jvm 0 0 0 2768 122 8m 50s Link

@borichellow borichellow added this pull request to the merge queue Feb 7, 2024
Merged via the queue into develop with commit 38ae5a6 Feb 7, 2024
18 checks passed
@borichellow borichellow deleted the fix/e2ei/get-my-cleints-certs-cherry-pick branch February 7, 2024 12:40
augustocdias pushed a commit that referenced this pull request Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants