-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support remote search by handle #2470
feat: support remote search by handle #2470
Conversation
* feat: support remote search by handle * detekt * address PR comments
Test Results2 523 tests - 370 2 449 ✔️ - 322 24s ⏱️ - 2m 18s Results for commit 742fc5d. ± Comparison against base commit c534b24. This pull request removes 2893 and adds 2523 tests. Note that renamed tests count towards both.
This pull request removes 122 skipped tests and adds 74 skipped tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2470 +/- ##
===========================================
Coverage 58.41% 58.41%
Complexity 21 21
===========================================
Files 1167 1171 +4
Lines 45083 45237 +154
Branches 4249 4257 +8
===========================================
+ Hits 26335 26425 +90
- Misses 16834 16892 +58
- Partials 1914 1920 +6
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 2 Passed Test Services
|
* feat: support remote search by handle * detekt * address PR comments Co-authored-by: Mohamad Jaara <[email protected]>
Cherry pick from the original PR:
PR Submission Checklist for internal contributors
The PR Title
The PR Description
What's new in this PR?
Issues
support search by handle in the new remote search first approach
Solutions
add a new use case to do searhc by handle
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References