Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: conference simulcast support (WPB-11480) (#3107) #3149

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Dec 6, 2024

StoryWPB-11480 [Android] Simulcast Support & Automatic Quality Adjustments

This reverts commit 9273703.


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

For safety reasons and looking for a stable version 4.10
Simulcast, we are going to be bumped out of this version.

Causes (Optional)

Rollback the commit

Needs release with


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. label Dec 6, 2024
@yamilmedina yamilmedina changed the title feat(revert): conference simulcast support (WPB-11480) (#3107) feat: revert - conference simulcast support (WPB-11480) (#3107) Dec 6, 2024
Copy link
Contributor

github-actions bot commented Dec 6, 2024

Test Results

3 340 tests  ±0   3 233 ✅ ±0   5m 48s ⏱️ -1s
  572 suites ±0     107 💤 ±0 
  572 files   ±0       0 ❌ ±0 

Results for commit f47501a. ± Comparison against base commit 212ddce.

♻️ This comment has been updated with latest results.

Copy link

sonarcloud bot commented Dec 6, 2024

@datadog-wireapp
Copy link

datadog-wireapp bot commented Dec 6, 2024

Datadog Report

Branch report: chore/downgrade-libs-4.10
Commit report: 539ec44
Test service: kalium-jvm

✅ 0 Failed, 3233 Passed, 107 Skipped, 1m 10.42s Total Time

Copy link
Contributor

github-actions bot commented Dec 6, 2024

🐰 Bencher Report

Branchchore/downgrade-libs-4.10
Testbedubuntu-latest

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles📈 view plot
⚠️ NO THRESHOLD
660,712.72
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory📈 view plot
⚠️ NO THRESHOLD
354,838,087.69
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark📈 view plot
⚠️ NO THRESHOLD
1,318,303,919.55
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark📈 view plot
⚠️ NO THRESHOLD
21,594,588.62
🐰 View full continuous benchmarking report in Bencher

@yamilmedina yamilmedina requested a review from saleniuk December 6, 2024 15:27
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 54.20%. Comparing base (06c284a) to head (f47501a).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
...tlin/com/wire/kalium/logic/data/call/CallClient.kt 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3149   +/-   ##
========================================
  Coverage    54.19%   54.20%           
========================================
  Files         1251     1249    -2     
  Lines        36429    36449   +20     
  Branches      3682     3688    +6     
========================================
+ Hits         19743    19756   +13     
- Misses       15267    15269    +2     
- Partials      1419     1424    +5     
Files with missing lines Coverage Δ
...tlin/com/wire/kalium/logic/data/call/CallClient.kt 0.00% <0.00%> (ø)

... and 17 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06c284a...f47501a. Read the comment docs.

@yamilmedina yamilmedina added this pull request to the merge queue Dec 6, 2024
@vitorhugods vitorhugods changed the title feat: revert - conference simulcast support (WPB-11480) (#3107) revert: conference simulcast support (WPB-11480) (#3107) Dec 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 6, 2024
@yamilmedina yamilmedina added this pull request to the merge queue Dec 6, 2024
Merged via the queue into develop with commit d8b69f1 Dec 6, 2024
29 checks passed
@yamilmedina yamilmedina deleted the chore/downgrade-libs-4.10 branch December 6, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. 👕 size: M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants