fix: change display name state [WPB-9653] (#3094)

wireapp · Jun 14, 2024 · 9297c06 · 9297c06
1 parent a573beb
commit 9297c06
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/...otlin/com/wire/android/ui/home/settings/account/displayname/ChangeDisplayNameViewModel.kt b/...otlin/com/wire/android/ui/home/settings/account/displayname/ChangeDisplayNameViewModel.kt
@@ -69,7 +69,7 @@ class ChangeDisplayNameViewModel @Inject constructor(
     ) {
         displayNameState = displayNameState.copy(loading = true)
         viewModelScope.launch {
-            updateDisplayName(textState.toString().trim())
+            updateDisplayName(textState.text.toString().trim())
                 .also { displayNameState = displayNameState.copy(loading = false) }
                 .let {
                     when (it) {

diff --git a/...n/com/wire/android/ui/home/settings/account/displayname/ChangeDisplayNameViewModelTest.kt b/...n/com/wire/android/ui/home/settings/account/displayname/ChangeDisplayNameViewModelTest.kt
@@ -28,9 +28,11 @@ import com.wire.kalium.logic.feature.user.GetSelfUserUseCase
 import com.wire.kalium.logic.feature.user.UpdateDisplayNameUseCase
 import io.mockk.MockKAnnotations
 import io.mockk.coEvery
+import io.mockk.coVerify
 import io.mockk.impl.annotations.MockK
 import kotlinx.coroutines.ExperimentalCoroutinesApi
 import kotlinx.coroutines.flow.flowOf
+import kotlinx.coroutines.test.advanceUntilIdle
 import kotlinx.coroutines.test.runTest
 import org.junit.jupiter.api.Assertions.assertEquals
 import org.junit.jupiter.api.Test
@@ -120,6 +122,21 @@ class ChangeDisplayNameViewModelTest {
         assertEquals(true, viewModel.displayNameState.saveEnabled)
     }
 
+    @Test
+    fun `given valid name, when updating, then should take only text value not the whole state toString`() = runTest {
+        val (arrangement, viewModel) = Arrangement()
+            .withUserSaveNameResult(DisplayNameUpdateResult.Success)
+            .arrange()
+
+        val newValue = "valid new name"
+        viewModel.textState.setTextAndPlaceCursorAtEnd(newValue)
+        advanceUntilIdle()
+
+        viewModel.saveDisplayName(onFailure = {}, onSuccess = {})
+
+        coVerify(exactly = 1) { arrangement.updateDisplayNameUseCase(newValue) }
+    }
+
     private class Arrangement {
 
         @MockK