feat: cert pinning #2124
feat: cert pinning #2124
Conversation
|
Build 1213 failed. |
|
Build 1215 failed. |
| isChangeEmailEnabled = BuildConfig.ALLOW_CHANGE_OF_EMAIL, | ||
| isLoggingEnabled = BuildConfig.LOGGING_ENABLED, | ||
| blacklistHost = BuildConfig.DEFAULT_BACKEND_URL_BLACKLIST, | ||
| fileRestrictionState = fileRestriction, | ||
| forceConstantBitrateCalls = BuildConfig.FORCE_CONSTANT_BITRATE_CALLS, | ||
| developerFeaturesEnabled = BuildConfig.DEVELOPER_FEATURES_ENABLED, | ||
| enableBlacklist = BuildConfig.ENABLE_BLACKLIST, | ||
| maxAccount = BuildConfig.MAX_ACCOUNTS, |
There was a problem hiding this comment.
those values are not used inside kalium so 💥
|
Build 1217 failed. |
MohamadJaara
requested review from
borichellow,
vitorhugods,
a team,
alexandreferris,
Garzas and
saleniuk
and removed request for
a team
|
Build 1249 failed. |
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 1255 succeeded. The build produced the following APK's: |
Codecov Report
@@ Coverage Diff @@
## develop #2124 +/- ##
==========================================
Coverage 40.66% 40.66%
Complexity 981 981
==========================================
Files 310 310
Lines 11381 11380 -1
Branches 1524 1524
==========================================
Hits 4628 4628
+ Misses 6314 6313 -1
Partials 439 439
Continue to review full report in Codecov by Sentry.
|
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 1256 succeeded. The build produced the following APK's: |
|
Build 1258 succeeded. The build produced the following APK's: |
|
APKs built during tests are available here. Scroll down to Artifacts! |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
implementing cert pinning for the android app
the cert and links are copied from the iOS implementation
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.