Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: attachments items arrangement [WPB-1840] #2302

Merged
merged 9 commits into from
Oct 6, 2023

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Oct 5, 2023

BugWPB-1840 Applause - [SG S20/A13] Chat - Message input mask - Unnecessary truncations of button titles


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Attachment buttons in some languages was not fitting in screen

Solutions

  • read longest word length by applied style and calculate minimum grid cell size
  • updated material library which solves crash in calling screen

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)

Before After
att_before att_after

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Test Results

629 tests  ±0   629 ✔️ ±0   8m 1s ⏱️ + 1m 43s
  92 suites ±0       0 💤 ±0 
  92 files   ±0       0 ±0 

Results for commit 820c8be. ± Comparison against base commit 2553247.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 1156 failed.

@AndroidBob
Copy link
Collaborator

Build 1164 succeeded.

The build produced the following APK's:

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

APKs built during tests are available here. Scroll down to Artifacts!

@Garzas Garzas enabled auto-merge October 5, 2023 13:29
@Garzas Garzas requested review from a team, typfel and vitorhugods and removed request for a team October 5, 2023 14:00
@Garzas Garzas added this pull request to the merge queue Oct 6, 2023
Merged via the queue into develop with commit 88bfae8 Oct 6, 2023
13 checks passed
@Garzas Garzas deleted the fix/attachments-items-arrangement branch October 6, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants