fix: hide speaker button from IncomingCallScreen (WPB-9031) #3099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohassine
requested review from
a team,
typfel,
MohamadJaara,
vitorhugods,
mchenani and
Garzas
and removed request for
a team
ohassine
changed the title
…g-call-screen' into hide-speaker-button-from-incoming-call-screen
|
Build 5300 failed. |
|
alexandreferris
approved these changes
Jun 14, 2024
|
Built wire-android-staging-release-pr-3099.apk is available for download |
|
Built wire-android-dev-debug-pr-3099.apk is available for download |
|
Build 5301 succeeded. The build produced the following APK's: |
Garzas
approved these changes
Jun 17, 2024
alexandreferris
deleted the
hide-speaker-button-from-incoming-call-screen
branch
echoes-hq
bot
added
the
echoes: unplanned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
When the app receives an incoming call, user should not enable/disable the speaker as the app should ring loudly
Solutions
Hide the speaker from incoming call screen
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
Attachments (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.