chore: ReactionPill using WireSecondaryButton #WPB-12094 #3648
+53
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
vitorhugods
approved these changes
Nov 20, 2024
MohamadJaara
approved these changes
Nov 26, 2024
saleniuk
approved these changes
Nov 26, 2024
echoes-hq
bot
added
the
echoes: unplanned
…eaction-paddings-refactor # Conflicts: # app/src/main/kotlin/com/wire/android/ui/home/conversations/messages/ReactionPill.kt # app/src/main/kotlin/com/wire/android/ui/home/conversations/messages/item/RegularMessageItem.kt
|
@damian-kaczmarek looks like you are rolling back kalium to a previous commitish. This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.
Is this intentional? |
|
|
Built wire-android-staging-compat-pr-3648.apk is available for download |
|
Built wire-android-dev-debug-pr-3648.apk is available for download |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
WIP: want to test all the cases it it works the same
ReactionPill looked very similar to WireSecondaryButton yet used own custom button.
Needs releases with:
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.