-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bulletproofing crypto box to cc migration (WPB-14250) #3658
chore: bulletproofing crypto box to cc migration (WPB-14250) #3658
Conversation
Built wire-android-staging-compat-pr-3658.apk is available for download |
@@ -29,7 +29,7 @@ | |||
"default_backend_url_blacklist": "https://clientblacklist.wire.com/staging", | |||
"default_backend_url_website": "https://wire.com", | |||
"default_backend_title": "wire-staging", | |||
"encrypt_proteus_storage": true, | |||
"encrypt_proteus_storage": false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for dev this should be fine since it is not used as a daily driver by anyone
Built wire-android-staging-compat-pr-3658.apk is available for download |
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #3658 +/- ##
=====================================================
- Coverage 45.34% 45.33% -0.02%
=====================================================
Files 471 471
Lines 15842 15848 +6
Branches 2655 2656 +1
=====================================================
Hits 7184 7184
- Misses 7885 7891 +6
Partials 773 773
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Built wire-android-staging-compat-pr-3658.apk is available for download |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
When enabling core crypto storage, if there are any Proteus clients, we need to migrate them from CryptoBox.
Things usually don't go as planned, so we need to have a recovery plan in place.
Causes (Optional)
There might be some errors while migrating.
Solutions
Implement a recovery plan for this case:
LogoutReason
, so we can act (cleanup) accordinglyIf everything goes smoothly, the user will be prompted to login again, preserving their local history.
Dependencies (Optional)
Needs releases with:
Testing
Test Coverage (Optional)
Notes (Optional)
Note
This approach seems "more correct", since if we try to create a new device only -as the ticket suggested- we will run into the issue of the refresh token not being valid anymore, since it was associated with the broken client that we were trying to migrate. And we can't associate the previous refresh token with a different client, we get a 403.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.