Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add username in settings #WPB-4368 #3663

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

damian-kaczmarek
Copy link
Contributor

@damian-kaczmarek damian-kaczmarek commented Nov 26, 2024

StoryWPB-4368 Remove link to user profile on app settings landing page

What's new in this PR?

Issues

  • remove user avatar from settings in top bar
  • add username in settings next to account details

Testing

Attachments (Optional)

Before After
image image

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@damian-kaczmarek damian-kaczmarek self-assigned this Nov 26, 2024
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Nov 26, 2024
Copy link
Contributor

Built wire-android-staging-compat-pr-3663.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3663.apk is available for download

@damian-kaczmarek damian-kaczmarek marked this pull request as ready for review November 26, 2024 12:53
…username-settings

# Conflicts:
#	app/src/main/kotlin/com/wire/android/ui/home/HomeTopBar.kt
Copy link

sonarcloud bot commented Nov 27, 2024

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 46.08%. Comparing base (90c9cba) to head (bd902e8).

Files with missing lines Patch % Lines
...wire/android/ui/home/settings/SettingsViewModel.kt 0.00% 10 Missing ⚠️
...com/wire/android/ui/home/settings/SettingsState.kt 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3663      +/-   ##
===========================================
- Coverage    46.11%   46.08%   -0.03%     
===========================================
  Files          472      472              
  Lines        16140    16150      +10     
  Branches      2674     2675       +1     
===========================================
  Hits          7443     7443              
- Misses        7919     7929      +10     
  Partials       778      778              
Files with missing lines Coverage Δ
.../com/wire/android/ui/home/settings/SettingsItem.kt 0.00% <ø> (ø)
...com/wire/android/ui/home/settings/SettingsState.kt 0.00% <0.00%> (ø)
...wire/android/ui/home/settings/SettingsViewModel.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90c9cba...bd902e8. Read the comment docs.

Copy link
Contributor

Built wire-android-staging-compat-pr-3663.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3663.apk is available for download

@damian-kaczmarek damian-kaczmarek added this pull request to the merge queue Nov 27, 2024
Merged via the queue into develop with commit f8ce21f Nov 27, 2024
11 of 12 checks passed
@damian-kaczmarek damian-kaczmarek deleted the feat/username-settings branch November 27, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants