Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scim logic: delete dangling external_ids if they happen. #4120

Merged
merged 5 commits into from
Jul 5, 2024
Merged

Fix scim logic: delete dangling external_ids if they happen. #4120

merged 5 commits into from
Jul 5, 2024

Conversation

fisx
Copy link
Contributor

@fisx fisx commented Jul 3, 2024 •
edited
Loading

https://wearezeta.atlassian.net/browse/WPB-9708

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Jul 3, 2024
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jul 3, 2024
supersven
supersven approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@supersven supersven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

fisx
fisx commented Jul 5, 2024
View reviewed changes
services/spar/src/Spar/Scim/User.hs
$ do
do
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change helps keep changes in indentation at a minimum. :)

@fisx fisx force-pushed the WPB-9708-fix-scim-user-gc-logic branch from 44edbf5 to 1caa5ec Compare July 5, 2024 21:19
@fisx fisx force-pushed the WPB-9708-fix-scim-user-gc-logic branch from 1caa5ec to f4d7b10 Compare July 5, 2024 21:24
@fisx fisx merged commit 506a880 into develop Jul 5, 2024
10 checks passed
@fisx fisx deleted the WPB-9708-fix-scim-user-gc-logic branch July 5, 2024 22:16
@zebot zebot mentioned this pull request Jul 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@supersven supersven supersven approved these changes

Assignees
No one assigned
Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fisx @supersven @zebot