Introduce VerificationCodeSubsystem #4121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echoes-hq
bot
added
echoes: technical-roadmap/throughput
zebot
added
the
ok-to-test
akshaymankar
force-pushed
the
wpb-8891/verification-code-subsystem
branch
6 times, most recently
from
a2fab76 to
287a89e
Compare
akshaymankar
force-pushed
the
wpb-8891/verification-code-subsystem
branch
from
287a89e to
bb775f6
Compare
pcapriotti
approved these changes
Jul 5, 2024
| defaulGen :: StdGen | ||
| defaulGen = mkStdGen 0xBAD | ||
|
|
||
| withStatefulGen :: (Member (State StdGen) r) => (StdGen -> (a, StdGen)) -> Sem r a |
There was a problem hiding this comment.
This could be generalised to any type s instead of StdGen.
There was a problem hiding this comment.
I was wondering why there is no modify, but thought probably because of lack of atomicity guarantees. So I decided to write a specific one. So I didn't bother generalizing it in this module.
There was a problem hiding this comment.
What do you mean? There is a modify, but this one is an analogue of the StateT constructor. As a rule of thumb, I think it's good to turn types like StdGen above into type variables, because that limits the ways they could be used incorrectly in the implementation. Not a huge concern here though, obviously.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-8891
Checklist
changelog.d