[WPB-14310] make existing registration api enterprise aware (cont.) #4437
Conversation
echoes-hq
bot
added
the
echoes/initiative: scale
zebot
added
the
ok-to-test
fisx
force-pushed
the
WPB-14310-make-existing-registration-api-enterprise-aware-3
branch
2 times, most recently
from
c89fc06 to
0c04736
Compare
|
|
||
| data DomainRegistration' = DomainRegistration' | ||
| { domain :: Domain, | ||
| settings :: DomainRegistrationSettings', |
There was a problem hiding this comment.
Can we make this a Maybe and remove the None case? I think preauthorized can also be outside of this, because its not really a setting, but its just a step in configuration. I think the main logic of wire-server (i.e. regsitrations and logins) are not affected by it being pre-authorized, it is treated the same as not having any config.
There was a problem hiding this comment.
right, domain was a hickup. and yes, maybe is nicer than none. 👍 bd36d47
There was a problem hiding this comment.
on second thought, the code is using the domain field in DomainRegistration a lot, and if we want to replace that with DomainRegistration', the code change in the logic would explode a little, and the new code wouldn't exactly be more concise.
i'll tentatively add the domain back in, let's see if i can convince you.
fisx
force-pushed
the
WPB-14310-make-existing-registration-api-enterprise-aware-3
branch
3 times, most recently
from
96afdab to
ed8021c
Compare
Also: - rename lots of stuff (necessary) - add more unit tests (roundtrip stuff)
fisx
force-pushed
the
WPB-14310-make-existing-registration-api-enterprise-aware-3
branch
from
14eb4ab to
2f28c05
Compare
DomainRegistrationResponse.authorized_team -> DomainRegistrationResponse.team this fixes a golden test that was broken before.
see comment in this commit.
This reverts commit 8c52286.
fisx
force-pushed
the
WPB-14310-make-existing-registration-api-enterprise-aware-3
branch
from
2a1ece6 to
8493363
Compare
battermann
force-pushed
the
WPB-14310-make-existing-registration-api-enterprise-aware-3
branch
from
9fe1e4e to
dfadaf9
Compare
…ting-registration-api-enterprise-aware-3' into WPB-14310-make-existing-registration-api-enterprise-aware-3
libs/wire-subsystems/src/Wire/EnterpriseLoginSubsystem/Interpreter.hs
Outdated
Show resolved
Hide resolved
…ting-registration-api-enterprise-aware-3' into WPB-14310-make-existing-registration-api-enterprise-aware-3
https://wearezeta.atlassian.net/browse/WPB-14310
Checklist
changelog.d