-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update community resources for migration guides #11376
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! And I think this wasn't a funny task so... 🙌🏽
I only left a few suggestions: some reorganization based on Firefox adaptive view, and two more generic comments (not necessarily an issue, but just to share in case you have better ideas than me 😄 ).
I'm not sure what we can do regarding the "strategic ordering of entries". I guess we could define the most recent links at the top to make them more visible but:
- This could conflict with space balancing
- If someone adds a new link, I guess the most logical position in this case is at the bottom so... this is not better than no ordering I guess.
src/content/docs/en/guides/migrate-to-astro/from-docusaurus.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/en/guides/migrate-to-astro/from-docusaurus.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Armand Philippot <[email protected]>
src/content/docs/en/guides/migrate-to-astro/from-create-react-app.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/en/guides/migrate-to-astro/from-docusaurus.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updating "add to the list" CTAs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! 🙌🏽 I only left a suggestion on cms/wordpress
to find a better balance.
Co-authored-by: Armand Philippot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description (required)
Updates the "Migrate to Astro from..." guides in the Community resources section to:
<LinkCard>
s (like the Gatsby one currently does) instead of Markdown linksAlso updates a few CMS/deploy guides when similar relevant community resources were found.
DRAFT:
This is a draft because I haven't yet previewed, nor thought about strategic ordering of entries. Just got all content added and committed quickly because I was having editor issues.
TO REVIEW:
Visit every Migration guide and check the bottom of the page (Community Resources section) for anything amiss! Link cards can be reordered if you see a better ordering!