-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Added Amplify SSR deployment instructions #11551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Hello! Thank you for opening your first PR to Astro’s Docs! 🎉 Here’s what will happen next:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without actually testing the steps themselves, this looks great @Zev18 ! It's really nicely written and matches the Astro Docs style.
I made two tiny suggestions. I think we can do away with the extra real estate of the note by just describing the non-official adapter in the sentence text. See what you think, and whether you think this is adequate to let people know it's not officially supported.
If anyone actually runs through the steps and confirms, please leave a review! I am reviewing based on the guide material only!
|
||
<PackageManagerTabs> | ||
<Fragment slot="pnpm"> | ||
```yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the title of this file? And where is this file located?
e.g. The GitHub Action for the GitHub pages deploy guide describes where to create this file like this:
It might be helpful to have similar guidance here.
You can add a title with the following Expressive Code syntax by providing a title
:
```yaml title="whatever.yml"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, this is the build settings yaml that lives in the amplify console. It's not part of the astro project, though it can be overwritten with an amplify.yaml
in the root dir iirc. I followed the existing Amplify docs' decision and didn't include a file name. Should I still title the file?
Co-authored-by: Sarah Rainsberger <[email protected]>
Description (required)
This pr adds instructions for deploying a project to Amplify as an SSR app. Instructions are based on AWS's own guide.
I'm pretty sure Amplify has changed, and the listed method for deploying a static site no longer works. I have tried it myself to no avail. I'm leaving it here in case anyone can prove me wrong, but if not then I think it should be deleted.
I've also added a link to Amazon's troubleshooting page for SSR deployments (I found this useful during my deployment), and marked AWS as compatible with SSR in the deploy guides navigation component.
Related issues & labels (optional)
Discord username: zev_ro