Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This adds support for linting Markdown component block using markdownlint.
Unlike other tools such as stylelint, Prettier or ESLint, markdownlint does not support formats other than the one it was intended for (
.md
) nor is it possible to write custom parsers for it nor does its VS Code extension support linting Markdown blocks in other filesSo, my first thought was that we needed to reimplement some parts of their VS Code extension into our language-server so I went ahead with that, but it turns out that we don't need that many code changes apart from a few things such as support for indented text
So, I'm thinking that instead of doing all this, we could probably contribute to markdownlint (at least its VS Code extension) and add support for linting blocks that are detected as
markdown
by VS Code (which is the case of our Markdown component)? Probably? However, that'll be for another fun weekendResult
Testing
WIP
Docs
WIP