feat(environment settings): added possibility to upload custom logo for monitoring environment #471
Conversation
| interface Response { | ||
| environment: Environment; | ||
| environmentRights: string[]; | ||
| userEnvironmentSettings: UserEnvironmentSettings, | ||
| userEnvironmentSettings: UserEnvironmentSettings; | ||
| environmentLogo: string | null; |
There was a problem hiding this comment.
requested change, I think
I would have imagined that the logo was part of the Environment model as:
// ...
logo?: FileFromServer | null,
// ...There was a problem hiding this comment.
I don't need whole FileFromServer
interface FileFromServer { hashId: string; requestorType: string; requestorHashId: string; url: string; signature: string; name: string | null; mimeType: string | null; bytes: number; md5: string; crc32: string; expiresAt: Date | null; }
Why send it all to UI part if I need only link?
There was a problem hiding this comment.
It was not about needing this info, but how the file is related to the environment, see https://github.com/withthegrid/platform/pull/2011#issuecomment-1453628465
|
requested change Also the connectivity environment doesn't have the same changes. I'd imagine that the 2 kinds of environments want a customisable logo. |
Is required for https://github.com/withthegrid/platform-client/pull/2033