Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] persistent worker integration into 2.x #3

Draft
wants to merge 69 commits into
base: master
Choose a base branch
from
Draft

Conversation

wiwa
Copy link
Owner

@wiwa wiwa commented Jan 25, 2023

No description provided.

@wiwa wiwa force-pushed the p/pw-with-int-2 branch 8 times, most recently from b47177d to bc4d38b Compare February 1, 2023 02:37
jasonschroeder-sfdc and others added 11 commits October 24, 2023 08:58
Don't get transitive grpc dependencies, use the ones from our `maven_install(...)`
Closes buildfarm#1508

Cleanups:
- remove the unused `ubuntu-bionic` base image
- replace `ubuntu-jammy:jammy-java11-gcc` with `ubuntu-mantic:mantic-java17-gcc`
- replace `amazoncorretto:19` with `ubuntu-mantic:mantic-java17-gcc`
- swap inverted log file names in a file
Specifying any number of OutputPaths will ignore OutputFiles (consistent
with uploads). Where an OutputPath specifies an output directory, the
action must be able to create the directory itself.
Partial specification of the absolute symlink response per REAPI.
Remaining work will be in output identification.
@wiwa wiwa force-pushed the p/pw-with-int-2 branch 6 times, most recently from 1eeffa6 to a88f62b Compare October 27, 2023 21:54
jasonschroeder-sfdc and others added 3 commits October 29, 2023 17:05
Trying to get more info on the Lombok stamping issue on Windows CI.
See also bazelbuild/bazel#10363 and
bazelbuild/bazel#18185
Default disabled, available with createSymlinkOutputs option in Worker
config.
@wiwa wiwa force-pushed the p/pw-with-int-2 branch 3 times, most recently from 3c6277c to e3b9e0d Compare November 9, 2023 22:47
rastenis and others added 8 commits November 9, 2023 19:52
…uildfarm#1530)

Add an option to provide a list of custom label headers to add to metrics.
Testing with bazel HEAD using jdk21 compilation has revealed new
direct dependencies on guava.
Annotations under lombok were fixed for jdk21 in 1.18.28, update to
current.
Remove acceptEverything DequeueMatchSetting
Place worker name in workerProvisions
Only enable allowUnmatched effects on key mismatch
Only acquire resources after asserting compatibility
Update documentation to match changes
Correct deprecated AccessController usage warning
Requires a newer bazel than 6.4.0 for macos to choose unix toolchain with C++ std=c++14 specification for protobuf->absl dependency.
Create a github workflow to build base buildfarm worker image.
@wiwa wiwa force-pushed the p/pw-with-int-2 branch 2 times, most recently from 3237c63 to 2ceb589 Compare November 14, 2023 18:14
@wiwa wiwa force-pushed the p/pw-with-int-2 branch 2 times, most recently from 59c9ca1 to 6217b6c Compare November 14, 2023 21:01
80degreeswest and others added 13 commits November 15, 2023 20:27
The execution platform property "cores" is detailed in documentation as
specifying "min-cores" and "max-cores". Match this definition and
prevent "cores" from being evaluated as a strict match with the worker
provision properties (with likely rejection).
Per the REAPI spec:

`The paths are relative to the working directory of the action
execution.`

Prefix the WorkingDirectory to paths used as OutputDirectory parameters,
and verify that these are present in the layout of the directory for
use.
Co-authored-by: Shane Delmore <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants