forked from buildfarm/buildfarm
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wip] persistent worker integration into 2.x #3
Draft
wiwa
wants to merge
69
commits into
master
Choose a base branch
from
p/pw-with-int-2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiwa
force-pushed
the
p/pw-with-int-2
branch
8 times, most recently
from
February 1, 2023 02:37
b47177d
to
bc4d38b
Compare
Don't get transitive grpc dependencies, use the ones from our `maven_install(...)`
To aid connection troubleshooting
buildfarm#1486) * Add unit test * Signal Write on complete
Closes buildfarm#1508 Cleanups: - remove the unused `ubuntu-bionic` base image - replace `ubuntu-jammy:jammy-java11-gcc` with `ubuntu-mantic:mantic-java17-gcc` - replace `amazoncorretto:19` with `ubuntu-mantic:mantic-java17-gcc` - swap inverted log file names in a file
Specifying any number of OutputPaths will ignore OutputFiles (consistent with uploads). Where an OutputPath specifies an output directory, the action must be able to create the directory itself.
Partial specification of the absolute symlink response per REAPI. Remaining work will be in output identification.
wiwa
force-pushed
the
p/pw-with-int-2
branch
6 times, most recently
from
October 27, 2023 21:54
1eeffa6
to
a88f62b
Compare
Trying to get more info on the Lombok stamping issue on Windows CI. See also bazelbuild/bazel#10363 and bazelbuild/bazel#18185
Default disabled, available with createSymlinkOutputs option in Worker config.
wiwa
force-pushed
the
p/pw-with-int-2
branch
3 times, most recently
from
November 9, 2023 22:47
3c6277c
to
e3b9e0d
Compare
…uildfarm#1530) Add an option to provide a list of custom label headers to add to metrics.
Testing with bazel HEAD using jdk21 compilation has revealed new direct dependencies on guava.
Annotations under lombok were fixed for jdk21 in 1.18.28, update to current.
Remove acceptEverything DequeueMatchSetting Place worker name in workerProvisions Only enable allowUnmatched effects on key mismatch Only acquire resources after asserting compatibility Update documentation to match changes
Correct deprecated AccessController usage warning Requires a newer bazel than 6.4.0 for macos to choose unix toolchain with C++ std=c++14 specification for protobuf->absl dependency.
Create a github workflow to build base buildfarm worker image.
wiwa
force-pushed
the
p/pw-with-int-2
branch
2 times, most recently
from
November 14, 2023 18:14
3237c63
to
2ceb589
Compare
wiwa
force-pushed
the
p/pw-with-int-2
branch
2 times, most recently
from
November 14, 2023 21:01
59c9ca1
to
6217b6c
Compare
The execution platform property "cores" is detailed in documentation as specifying "min-cores" and "max-cores". Match this definition and prevent "cores" from being evaluated as a strict match with the worker provision properties (with likely rejection).
Per the REAPI spec: `The paths are relative to the working directory of the action execution.` Prefix the WorkingDirectory to paths used as OutputDirectory parameters, and verify that these are present in the layout of the directory for use.
Co-authored-by: Shane Delmore <[email protected]>
Co-authored-by: Shane Delmore <[email protected]>
…rTest Co-authored-by: Shane Delmore <[email protected]>
Co-authored-by: Shane Delmore <[email protected]>
wiwa
force-pushed
the
p/pw-with-int-2
branch
from
November 19, 2023 04:32
6217b6c
to
20cd93e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.