fix calling VersionFactory::fromString with an invalid string

wizacode · Jan 22, 2019 · 860f065 · 860f065
1 parent bbc2e77
commit 860f065
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/VersionFactory.php b/src/VersionFactory.php
@@ -32,7 +32,7 @@ public static function fromString(string $versionString): Version
             self::REGEXP_DOT_SEPARATED_IDENTIFIERS
         );
 
-        if (false === preg_match($regexp, $versionString, $matches, PREG_UNMATCHED_AS_NULL)) {
+        if (1 !== preg_match($regexp, $versionString, $matches, PREG_UNMATCHED_AS_NULL)) {
             throw new \RuntimeException('Version string does not follow semantic versioning: ' . $versionString);
         }
 

diff --git a/tests/VersionFactoryTest.php b/tests/VersionFactoryTest.php
@@ -33,4 +33,10 @@ public function testNextPatch()
     {
         $this->assertEquals(new Version(1, 2, 4), VersionFactory::nextPatch(new Version(1, 2, 3)));
     }
+
+    public function testFromStringEmpty()
+    {
+        $this->expectException(RuntimeException::class);
+        VersionFactory::fromString('');
+    }
 }