-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gui: add support for tapminiscript on bitbox02 #1400
gui: add support for tapminiscript on bitbox02 #1400
Conversation
05a4f01
to
55fb7a4
Compare
Note: @benma do you plan to release a new version of the crate or we should release on top of your GH master branch? |
55fb7a4
to
0aa809e
Compare
I published https://crates.io/crates/bitbox-api v0.6.0 which includes the necessary changes. |
0aa809e
to
01f6d2b
Compare
rebased on master, so now uses |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 01f6d2b
Tested for a tr(2of2->3blocks->2of1) registration, address verification, spending and recovery
@edouardparis did you also test using multiple inputs but using same xpub in both primary and recovery to see if the filtering works? The BitBox only signs for one keypath per input, and the one it picks from the PSBT is arbitary so it could go wrong if for one input it signs for the primary and for the second input it signs for the secondary keypath. |
Thanks for the reminder, I just tested it with the two inputs and the decaying multisig that has the bitbox xpub in both paths and it works as expected. The PR also does not touch the previous logic of removing misleading bip32 derivation. |
This PR is build on top of #1357, with few adds:
tap_script_signs
&tap_key_sig
if present in the pruned psbt after signatureTested spending by internal key & taptree w/ differents setups
Note: this PR usebitbox-tapminiscript
branch ofasync-hwi