Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

liana: remove daemon feature #1469

Merged

Conversation

edouardparis
Copy link
Member

@edouardparis edouardparis commented Nov 18, 2024

We expect user to use systemd service to manage a daemon or
to handle their process by themself.

The json-rpc server is exposed only for unix systems through
unix sockets, it is moved to its own module while the implementation
for windows is marked as TODO.

@edouardparis edouardparis changed the title wip: remove daemon feature liana: remove daemon feature Nov 18, 2024
@pythcoiner
Copy link
Collaborator

pythcoiner commented Nov 18, 2024

we should check if #255 and #414 can be closed after merging this (but i don't believe libc was used only for forking the process...)

@edouardparis
Copy link
Member Author

You are right, libc is required by rust anyway to call OS-level functions and system calls directly. I do not think the current change resolves #255 and #414

Copy link
Collaborator

@jp1ac4 jp1ac4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to run lianad, executing CLI commands and running the GUI.

As well as my comment in the code, I think you can also remove the StartupError::Daemonization variant now.

liana/src/config.rs Show resolved Hide resolved
We expect user to use systemd service to manage a daemon or
to handle their process by themself.

The json-rpc server is exposed only for unix systems through
unix sockets, it is moved to its own module while the implementation
for windows is marked as TODO.
@edouardparis
Copy link
Member Author

rebased and fixed @jp1ac4 comments

Copy link
Collaborator

@jp1ac4 jp1ac4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK c14c55b.

@edouardparis edouardparis merged commit 9c6eae9 into wizardsardine:master Nov 19, 2024
24 checks passed
@edouardparis edouardparis deleted the remove-liana-daemon-feature branch November 19, 2024 09:28
@pythcoiner
Copy link
Collaborator

tACK c14c55b run GUI and lianad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants