-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
liana: remove daemon feature #1469
liana: remove daemon feature #1469
Conversation
1a511e9
to
6ce083e
Compare
bb79b81
to
aeb16fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to run lianad, executing CLI commands and running the GUI.
As well as my comment in the code, I think you can also remove the StartupError::Daemonization
variant now.
We expect user to use systemd service to manage a daemon or to handle their process by themself. The json-rpc server is exposed only for unix systems through unix sockets, it is moved to its own module while the implementation for windows is marked as TODO.
f8f540b
to
c14c55b
Compare
rebased and fixed @jp1ac4 comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK c14c55b.
tACK c14c55b run GUI and lianad |
We expect user to use systemd service to manage a daemon or
to handle their process by themself.
The json-rpc server is exposed only for unix systems through
unix sockets, it is moved to its own module while the implementation
for windows is marked as TODO.