database: store whether coin is from self #1483
Open
+935
−125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some migration tests used structs and methods that are expected to change and so will not be backward compatible. This change replaces those with structs and methods specific to the migration tests so that the tests will be unaffected by DB schema changes. At the same time, these new structs and methods simplify some of the setup by allowing to store new coins, including their confirmation and spend status, in a single DB operation.
This adds a new `is_from_self` column to the coins table that indicates if the coin is an output of a transaction for which all inputs are ours. In the case of unconfirmed coins, being from self requires that all unconfirmed ancestors, if any, are also from self. The DB migration sets the value of this column for all existing coins and the poller keeps the column up to date.
jp1ac4
force-pushed
the
store-coin-is-from-self
branch
from
bbcfb76
to
07b2651
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first step towards #1375.
Following the approach from #1391, it adds a new
is_from_selfcolumn to the coins database table to track which coins are fully controlled by the user's wallet. This PR is limited to adding the column and keeping it updated in the poller.This column could instead have been added to the transactions table, but for consistency with other transaction-related columns, I added it to the coins table. It's also important to note that being from self is wallet-dependent, so adding it to the transactions table would not work if multiple wallets were supported in the same DB (h/t @edouardparis).
Subsequent PRs will then return this field in the
listcoinscommand, which the GUI can then use to determine which unconfirmed coins, if any, can be included in the confirmed balance. Another use of this field will be to determine which unconfirmed coins to include in coin selection (#1484).The first commit in this PR refactors some existing DB migration tests so that they will not be affected by future changes to the coins table schema.