Custom dtype improvements #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit generalizes the interface for registering custom dtypes with the ``nb::ndarray`` class. In particular, the previous version had hardcoded members like ``is_float``, ``is_int``, etc., which is not general enough to express nuances like ``bfloat16`` or 8-bit FP types with different numbers of exponent and mantissa bits. The new interface just lets the developer populate a ``nb::dlpack::dtype`` record manually and provide a type name for use in docstrings and error messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit generalizes the interface for registering custom dtypes with the
nb::ndarrayclass. In particular, the previous version had hardcoded members likeis_float,is_int, etc., which is not general enough to express nuances likebfloat16or 8-bit FP types with different numbers of exponent and mantissa bits.The new interface just lets the developer populate a
nb::dlpack::dtyperecord manually and provide a type name for use in docstrings and error messages.