[WIP] Support Eigen::Map<Eigen::SparseMatrix> #782
+163
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Alec, thank you very much for working on this, zero-copy sparse matrix passing will be useful. There were still some internal comments and questions inside the PR, so I am assuming that it is still in progress. Please let me know if/when you'd like me to do a review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If completed would fix #781.
Phew, I learned a lot poking around, but I'm mostly just cribbing the original Eigen::SparseMatrix support. I have barely tested any of this. I will use this PR to add tests etc.