make_iterator: accept args by value, not forwarding reference, so that passing lvalue iterators works #788
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reasonable-looking way to expose
std::map::equal_range()
to Python:Unfortunately, it dangles:
range.first
has typeMapType::iterator&
, so deducingIterator&&
from it yieldsIterator = MapType::iterator&
, so a reference gets stored in the iteratorstate
object. But that reference refers to the stack-allocatedrange
object, which will be destroyed before the Python iterator is used. This PR changesmake_iterator
(and friends) arguments to accept their iterator and sentinel by value, to avoid this dangling risk. You can still get reference semantics by specifying the template arguments explicitly.Also resolve ambiguity between the iterator and range overloads of
make_iterator
, and clean up the docs to reflect the iterator/sentinel split.