Add ANIMartRIX usermod

[netmindz]

New usermod that makes the ANIMartRIX effects available to WLED

[blazoncek]

Where do you get <ANIMartRIX.h> from?
It is not included with source files.

I've seen in your repo that you include your custom lib_deps, perhaps adding that info to readme.md would be good.

[netmindz]

I wasn't sure what the normal practice was AC and deps of usermods? I didn't just want to slam in a dep into all builds. I don't know of a way of adding lib_deps based on the USERMOD_ANIMARTRIX flag

[netmindz]

Readme updated

[blazoncek]

My recommendation would be to include all dependencies in usermod folder if all of the files are mature (if all files are under your control).
If, on the other hand, you consider Animartrix.h to be WIP then using lib_deps is a viable choice. Though I would avoid using commit ID.

[netmindz]

The refactor to make it an OO library is a work in progress, so no version release tags not finalised API, so to ensure consistent builds, best practice to lock to a given revision, not just to a WIP branch

[netmindz]

Updated to have speed control too

[netmindz]

The commit Id is listed so that we get repeatable builds @blazoncek

[blazoncek]

The commit Id is listed so that we get repeatable builds @blazoncek

I'm sorry, but I do not understand.

One more thing. Can you re-base this for 0_15 branch?

[netmindz]

The commit Id is listed so that we get repeatable builds @blazoncek

I'm sorry, but I do not understand.

One more thing. Can you re-base this for 0_15 branch?

When defining any library dependencies in platformio it's always best to point at a specific release tag, rather than head of master/main as otherwise suddenly your own builds can start failing if some breaking change is pushed or it works for some folk, but not others as they have pulled different versions.

As I haven't created a release as my branch is actually a PR back to the main repo, I'm depending on a specific commit to provide the same level of build stability/repeatability

As for 0_15, yeah I can create a fresh PR based off that if you like.

Is there anything else that needs to be addressed or are you otherwise happy with this code?

[blazoncek]

Thank you. If you consider it finished then I'm ok with it.
You can just pull 0_15 into your branch, push and then update target of this PR. No need to reopen new PR.

[netmindz]

Specifically 0_15 or just pull in updates on dev?

[blazoncek]

0_15 from Aircoookie repo. It is most recent with updates from a few seconds ago.

[netmindz]

New PR created for fresh branch