Switch to willmmiles fork of AsyncWebServer (0_15) #3741
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willmmiles
force-pushed
the
0_15-willmmiles-webserver
branch
4 times, most recently
from
be361b9 to
48a5e4f
Compare
Enable concurrent request and queue size limit features of the willmmiles fork of AsyncWebServer. This should reduce the risk of OOM crashes.
Release the json buffer lock as soon as we've finished serializing. This should slightly reduce the number of lock collisions as the response class isn't destructed until after the last packet is ack'd.
It's not permissible to call delay during AsyncWebServer callbacks, and it doesn't help on single-core systems. Add a quick exit path for these cases.
Use the web server's queuing mechanism to call us back later.
Make the low heap debugging messages stand out more in a trace.
These were mostly PROGMEM already, but every little bit helps.
Rather than relying on the exception handler, indicate the __FlashStringHelper type so the correct String constructor is used.
Eliminate the extra indirection and allocate shared buffers directly.
willmmiles
force-pushed
the
0_15-willmmiles-webserver
branch
from
48a5e4f to
1e82c13
Compare
|
Closing this one - I think it'll be better managed in smaller updates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As for #3740, but on 0_15.
Switch WLED to use the willmmiles fork of AsyncWebServer, with the following improvements:
This should be considered an alpha-quality work in progress; I'm offering it here for early testing and feedback. Version number is not pinned yet.