Pin ArduinoFFT version #3800
Pin ArduinoFFT version #3800
Conversation
The upstream repository has released an incompatible commit on that branch. Pin the last commit before the new version was merged.
|
IMO we're better off accepting new API and modify AR usermod. @softhack007 your thoughts? This was also my request there: kosme/arduinoFFT#74 |
I agree that we should update to the new version soon. I suggested this patch as a safe, short term fix as the GitHub CI system is now reporting build failures for all PRs, and clean checkouts won't build anymore either unless your local PlatformIO has already cached the old version. |
|
Resolved by using release version 2.0.0 of ArduinoFFT. |
Looks good 👍 wow it's still a surprise that ArduinoFFT got a new release - the first update after 3 years or so. |
|
Good enough for me - I didn't have hardware on hand to test any changes, I just wanted the CI to work :) |
The upstream repository has updated the develop branch to v2.0 which is not API compatible. Pin the last commit before the new version was merged.