Enable aggregated Requests #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the number of titles (for the titles) parameter in a request exceeds the maximum allowed one of 50, the client not transparently does multiple requests and aggregates the results. This may come into play when retrieving the 'imageInfo' for all files from an article.
Since we're now combining pages in the client already, we need to make sure pages are actually available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small leftover from today: this enables aggregated responses for requests to the Wikimedia / Wikipedia API where the
titlesparameter exceeds the maximum allowed number of titles one is allowed to query for via the API - 50.In this case, we're now doing multiple requests and then aggregate the
pagesfrom them so that what theClientreturns still says transparent for the services.There are still some things to take care of though:
pagesobjectpagesin the services (it's now done in the client)