Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T345689 semver #479

Closed
wants to merge 22 commits into from
Closed

T345689 semver #479

wants to merge 22 commits into from

Conversation

rti
Copy link
Contributor

@rti rti commented Sep 21, 2023 •
edited
Loading

Depends on #478, please review first.

This PR:

  • adds tagging built docker images with semver versions configured in the channel they are built for
  • refactors some of the build scripts in order to DRY

The images are tagged with the following strategy:

Prerelease images get the following tags:

  • service-name-X.Y.Z-pre.I-build-REV-TIMESTAMP-BRANCH like wikibase-bundle-2.0.0-pre.1-build-cf84af2-20230926142936-T345689-semver
  • service-name-X.Y.Z-pre.I like wikibase-bundle-2.0.0-pre.1
  • so they do not overwrite any tags that might have been used by previous builds
  • so users will never pull those images automatically

RELEASE images get the following tags:

  • service-name-X.Y.Z-build-REV-TIMESTAMP-BRANCH like wikibase-bundle-2.0.0-build-cf84af2-20230926142936-T345689-semver
  • service-name-X.Y.Z like wikibase-bundle-2.0.0
  • service-name-X.Y like wikibase-bundle-2.0
  • service-name-X like wikibase-bundle-2
  • so they DO overwrite previous builds for the same MAJOR.MINOR and MAJOR version
  • so users might auto update to those builds when they "subscribed" to the respective versions

@rti rti mentioned this pull request Sep 26, 2023
Closed
@rti rti marked this pull request as ready for review September 26, 2023 14:40
@rti rti requested a review from a team September 27, 2023 09:36
rti and others added 9 commits September 27, 2023 11:48
@rti
chore: try flatten dirs in .github
661c4db
@rti
Merge remote-tracking branch 'origin/main' into T345689-build-three-v…
d190109 
…ersions-plain
@rti
fix: date format in env files
8f9fabd
@rti
Revert "chore: try flatten dirs in .github"
5c8abca 
This reverts commit 661c4db.
@rti
docs: make test CHANNEL
de25115
@rti
fix: test-all with channel
c5ccab2
@rti
docs: update
533ef89
@rti
Merge remote-tracking branch 'origin/main' into T345689-build-three-v…
14d6651 
…ersions-plain
@rti
feat: initial semver
3acb4f7 
fix: missing docker_tag.sh

fix: add required builder env

fix: rm mv

fix: spelling of file name

chore: skip version test for now

fix: do not docker save all builds

fix: save only the just built docker tag, but with all tags

fix(lint/shellcheck): do not complain about source'ing

chore: remove RELEASE_VERSION variable

chore: remove RELEASE_MAJOR_VERSION var

chore: remove MEDIAWIKI_MAJOR_VERSION var
@rti rti marked this pull request as draft November 1, 2023 09:40
@lorenjohnson
Copy link
Contributor

@rti is this still relevant or will it need to be re-approached now that we've merged #478?

@rti
Copy link
Contributor Author

rti commented Dec 5, 2023

@lorenjohnson good catch. Yes, that can be closed and needs to be re-approached.

@rti rti closed this Dec 5, 2023
@rti rti deleted the T345689-semver branch June 24, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rti @lorenjohnson