Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T346214 await displayed #490

Merged
merged 9 commits into from
Oct 24, 2023
Merged

T346214 await displayed #490

merged 9 commits into from
Oct 24, 2023

Conversation

RickiJay-WMDE
Copy link
Member

@RickiJay-WMDE RickiJay-WMDE commented Oct 16, 2023

awaitDisplayed

If a string is passed, await finding that element. If a promise of an element is passed, await the element. In any case, wait until the element is displayed. Return the element.

SubmittablePage

A page with a submit() method and a submitBtn, inheritable. We had the exact same submit() method implemented thrice.

@RickiJay-WMDE RickiJay-WMDE marked this pull request as ready for review October 18, 2023 08:16
Copy link
Contributor

@rti rti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💜💜💜 nice work. Thanks a lot!

@RickiJay-WMDE RickiJay-WMDE merged commit 86c994a into main Oct 24, 2023
@RickiJay-WMDE RickiJay-WMDE deleted the T346214-await-displayed branch October 24, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants