-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
T349718 property list test #493
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rti
force-pushed
the
T349718-property-list-test
branch
from
October 26, 2023 13:06
e903cc4
to
3e1fdf6
Compare
Tests not passing, please flag for re-review once things are green :) |
Green now. Sorry for that! |
RickiJay-WMDE
approved these changes
Nov 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
rti
added a commit
that referenced
this pull request
Nov 9, 2023
* test(property-list): reproduce new property not shown issue * fix: configure cache and wait for it to timeout * fix: lint * fix: list of properties page test for more than 50 properties
Merged
rti
added a commit
that referenced
this pull request
Nov 9, 2023
RickiJay-WMDE
pushed a commit
that referenced
this pull request
Nov 9, 2023
* test(property-list): reproduce new property not shown issue * fix: configure cache and wait for it to timeout * fix: lint * fix: list of properties page test for more than 50 properties
RickiJay-WMDE
added a commit
that referenced
this pull request
Nov 13, 2023
* string * No display * Fix * Replace * Not identifiers * Not Identifier * Additional Wait * Remove Commented Lines * Chainable * Fixes * Lint * Organize * fix(github-actions): GHCR upload (#505) * fix(github-actions): GITHUB_TOKEN access for GHCR upload * fix(github-actions): docker image name * chore: move if to job level * fix: get built docker artifacts in ghcr upload job * fix(github-actions): ghcr image name * chore: run upload ghcr only on main and mw-?.?? branches * fix: simplify job run check, we do not have regex here :( * T349718 property list test (#493) * test(property-list): reproduce new property not shown issue * fix: configure cache and wait for it to timeout * fix: lint * fix: list of properties page test for more than 50 properties * fix: change upgrade test 1.39 base version to latest (#508) * chore: change upgrade test 1.39 base version to latest * fix: add missing env files * Lint * Remove comment * Remove * Pause * Repo * Quickstatements * Repo Client * Fedprops * Elasticsearch * Helpers --------- Co-authored-by: Loren Johnson <[email protected]> Co-authored-by: rti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://phabricator.wikimedia.org/T349718