Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T349718 property list test #493

Merged
merged 5 commits into from
Nov 9, 2023
Merged

T349718 property list test #493

merged 5 commits into from
Nov 9, 2023

Conversation

rti
Copy link
Contributor

@rti rti commented Oct 25, 2023

@rti rti force-pushed the T349718-property-list-test branch from e903cc4 to 3e1fdf6 Compare October 26, 2023 13:06
@rti rti marked this pull request as ready for review October 26, 2023 13:07
@rti rti requested a review from a team October 26, 2023 13:07
@lorenjohnson
Copy link
Contributor

Tests not passing, please flag for re-review once things are green :)

@rti rti marked this pull request as draft October 31, 2023 10:34
@rti rti marked this pull request as ready for review November 1, 2023 09:39
@rti
Copy link
Contributor Author

rti commented Nov 1, 2023

Tests not passing, please flag for re-review once things are green :)

Green now. Sorry for that!

Copy link
Member

@RickiJay-WMDE RickiJay-WMDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rti rti merged commit afeba85 into main Nov 9, 2023
29 checks passed
@rti rti deleted the T349718-property-list-test branch November 9, 2023 08:02
rti added a commit that referenced this pull request Nov 9, 2023
* test(property-list): reproduce new property not shown issue

* fix: configure cache and wait for it to timeout

* fix: lint

* fix: list of properties page test for more than 50 properties
@rti rti mentioned this pull request Nov 9, 2023
rti added a commit that referenced this pull request Nov 9, 2023
* test(property-list): reproduce new property not shown issue

* fix: configure cache and wait for it to timeout

* fix: lint

* fix: list of properties page test for more than 50 properties
RickiJay-WMDE pushed a commit that referenced this pull request Nov 9, 2023
* test(property-list): reproduce new property not shown issue

* fix: configure cache and wait for it to timeout

* fix: lint

* fix: list of properties page test for more than 50 properties
RickiJay-WMDE added a commit that referenced this pull request Nov 13, 2023
* string

* No display

* Fix

* Replace

* Not identifiers

* Not Identifier

* Additional Wait

* Remove Commented Lines

* Chainable

* Fixes

* Lint

* Organize

* fix(github-actions): GHCR upload (#505)

* fix(github-actions): GITHUB_TOKEN access for GHCR upload

* fix(github-actions): docker image name

* chore: move if to job level

* fix: get built docker artifacts in ghcr upload job

* fix(github-actions): ghcr image name

* chore: run upload ghcr only on main and mw-?.?? branches

* fix: simplify job run check, we do not have regex here :(

* T349718 property list test (#493)

* test(property-list): reproduce new property not shown issue

* fix: configure cache and wait for it to timeout

* fix: lint

* fix: list of properties page test for more than 50 properties

* fix: change upgrade test 1.39 base version to latest (#508)

* chore: change upgrade test 1.39 base version to latest

* fix: add missing env files

* Lint

* Remove comment

* Remove

* Pause

* Repo

* Quickstatements

* Repo Client

* Fedprops

* Elasticsearch

* Helpers

---------

Co-authored-by: Loren Johnson <[email protected]>
Co-authored-by: rti <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants