Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wdio-mediawiki 2.4.0 - Remove Local Patches #494

Merged
merged 19 commits into from
Nov 17, 2023
Merged

Conversation

RickiJay-WMDE
Copy link
Member

@RickiJay-WMDE RickiJay-WMDE commented Oct 26, 2023

The code changes we've made to wdio-mediawiki will eliminate the need for our patches; this updates to wdio-mediawiki 2.4 and removes our local patch files.

The foundation is planning on reverting our changes as, I believe, 2.5.0 as soon as I indicate that 2.4 works for us, and they're taking a different approach when they go to wdio v8 - they don't want to be backwards compatible with wdio v7, so that'll be wdio-mediawiki 3.0.0. We'll need to NOT update to 2.5, and update our code to be compatible with theirs when they publish 3.0.

RickiJay-WMDE and others added 19 commits October 26, 2023 14:50
* docs: add links for github and docker hub access tokens

* docs(publishing): local.env example

* docs: remove note about tagging
* feat: initial 1.39.5 env

* fix: workflow to pickup wmde13

* docs: change log

* docs: url

* docs: fix wikibase changelog link

* docs: add github run number

* chore: add build metadata

* chore: update example dir to wmde.13

* fix: update test from versions

* fix: add missing env files for upgrade tests
@RickiJay-WMDE RickiJay-WMDE changed the title DO NOT MERGE - Local wdio-mediawiki Test wdio-mediawiki 2.4.0 - Remove Local Patches Nov 17, 2023
@RickiJay-WMDE RickiJay-WMDE requested a review from a team November 17, 2023 09:52
@RickiJay-WMDE RickiJay-WMDE marked this pull request as ready for review November 17, 2023 09:52
Copy link
Contributor

@rti rti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a journey! Congratz!! Approved!

@RickiJay-WMDE RickiJay-WMDE merged commit 671819d into main Nov 17, 2023
26 checks passed
@RickiJay-WMDE RickiJay-WMDE deleted the wdio-mediawiki-local branch November 17, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants