fix: gh built artifact names #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
LGTM, but I'm not sure whether to approve or wait for @datn? |
lorenjohnson
approved these changes
Nov 21, 2023
rti
added a commit
that referenced
this pull request
Nov 21, 2023
rti
added a commit
that referenced
this pull request
Nov 21, 2023
This was referenced Nov 21, 2023
rti
added a commit
that referenced
this pull request
Nov 27, 2023
rti
added a commit
that referenced
this pull request
Nov 27, 2023
RickiJay-WMDE
pushed a commit
that referenced
this pull request
Nov 29, 2023
rti
added a commit
that referenced
this pull request
May 16, 2024
* Set variables.env to wmde.13 values * Test mw-* branches (#503) (#504) * fix(github-actions): GHCR upload (#505) (#509) * fix(github-actions): GITHUB_TOKEN access for GHCR upload * fix(github-actions): docker image name * chore: move if to job level * fix: get built docker artifacts in ghcr upload job * fix(github-actions): ghcr image name * chore: run upload ghcr only on main and mw-?.?? branches * fix: simplify job run check, we do not have regex here :( * feat: upload to GHCR from prep-mw- branches as well (#514) (#516) * fix(github-actions-workflow): ghcr upload base_ref check (#518) (#521) * fix: gh built artifact names (#512) (#527) * chore: update variables.env to new format use commit hashes from WMDE.13 release CI build https://phab.wmfusercontent.org/file/download/67e7x2izldkdqmqexnwe/PHID-FILE-atrxuifwzod3ur25xju5/BuildMetadata.zip * fix: update test the correct versions in CI * Release 1.39.6 (#568) * Manually backporting formatting changes * Revert "Releaseprep wmde.17 (#607)" This reverts commit 090be85. * Delete build_and_test * Fix image urls * Lint * Lint * Revert cont. * Fix upgrade path * Release prep * Final release version * Set release date * Update example (#668) --------- Co-authored-by: Ricki Jay <[email protected]> Co-authored-by: Ricki <[email protected]> Co-authored-by: adeeri <[email protected]> Co-authored-by: adeeri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the merge of 7686b1a built artifact names changed. This PR fixes some docs and scripts that still used to old names.
❗ should probably be backported to
mw-1.39andmw-1.40